Skip to content

fix column ordering#1753

Merged
lyubov-voloshko merged 1 commit into
mainfrom
fix-column-order
May 5, 2026
Merged

fix column ordering#1753
lyubov-voloshko merged 1 commit into
mainfrom
fix-column-order

Conversation

@lyubov-voloshko
Copy link
Copy Markdown
Collaborator

@lyubov-voloshko lyubov-voloshko commented May 5, 2026 •
edited by coderabbitai Bot
Loading

Summary by CodeRabbit

  • Bug Fixes
    • Table columns now maintain proper ordering when customized, displaying selected columns first for better visibility and organization.

Copilot AI review requested due to automatic review settings May 5, 2026 10:29
@lyubov-voloshko lyubov-voloshko enabled auto-merge May 5, 2026 10:29
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 5, 2026 •
edited
Loading

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cf290591-6ba1-417b-9a0a-b6bf1a50dbbe

📥 Commits

Reviewing files that changed from the base of the PR and between 6a0fb7d and fd21299.

📒 Files selected for processing (1)
  • frontend/src/app/components/dashboard/db-table-view/db-table-view.component.ts
📝 Walkthrough

Walkthrough

The PR modifies column persistence logic in the database table view component to reorder columns so selected ones appear first, followed by non-selected ones, when saving personal table settings.

Changes

Column Ordering Persistence

Layer / File(s) Summary
Core Logic
frontend/src/app/components/dashboard/db-table-view/db-table-view.component.ts		 onColumnsMenuDrop now constructs orderedColumns by grouping selected columns before non-selected columns, then sends orderedColumns.map(col => col.title) to updatePersonalTableViewSettings instead of the unordered columns.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Column order neat and bright,
Selected ones now sit just right,
First in line, they take their place,
A tidy table, full of grace! ✨

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix column ordering' directly and clearly summarizes the main change: fixing how column ordering is persisted in the table view component.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Security Check ✅ Passed Column ordering change is secure. Backend validates all list_fields against table structure before storage. No authorization, injection, or exposure risks introduced.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-column-order

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lyubov-voloshko lyubov-voloshko merged commit f850e56 into main May 5, 2026
16 of 18 checks passed
@lyubov-voloshko lyubov-voloshko deleted the fix-column-order branch May 5, 2026 10:32
Copilot AI reviewed May 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts how column order is persisted when a user reorders columns in the table-view columns menu, ensuring the saved ordering places visible (selected) columns first and hidden columns afterward.

Changes:

  • Builds an orderedColumns array (selected first, then unselected) when saving personal table view settings.
  • Persists list_fields using this ordered list instead of the raw tableData.columns order.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lyubov-voloshko